Various code cleanup #1195
Merged
Various code cleanup #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Anaconda test suite is failing because the use stringize and unicodeize, see rhinstaller/anaconda#5440 |
We stopped caring about Python 2 support long time ago and with libblockdev 3.0 which is Python 3 only it wouldn't even be possible to support Python 2 so we should finally remove it.
These are needed only for the Pytho 2/3 compatibility and we no longer support Python 2. unicodeize can be removed without replacement and the default str constructor can replace stringize.
We no longer support older versions of Python so we can import everything only from the unittest module.
vojtechtrefny
force-pushed
the
3.10-devel_python2-support-remove
branch
from
736f6df
to
a45bc29
Compare
vojtechtrefny
force-pushed
the
3.10-devel_python2-support-remove
branch
from
a45bc29
to
d212b7b
Compare
vojtechtrefny
merged commit f7db1ea
into
storaged-project:3.10-devel
9 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed last remnants of Python 2 support and some code cleanup mostly in tests.